Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrong host password error message #134

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

Christian-Holbrook
Copy link
Contributor

@Christian-Holbrook Christian-Holbrook commented Dec 13, 2023

Improves the "wrong password" error message.

@TwitchBronBron TwitchBronBron merged commit 1ca7f51 into master Dec 14, 2023
6 checks passed
@TwitchBronBron TwitchBronBron deleted the update-unauthorized-message branch December 14, 2023 00:20
TwitchBronBron added a commit that referenced this pull request Apr 30, 2024
* Update wrong host password error message (#134)

* Update wrong host password error message

* Fix unit test to look for the updated message

* Get 100% code coverage

* Update changelog for v3.11.2

* 3.11.2

* Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error (#145)

* Retry the convertToSquahsfs request given the HPE_INVALID_CONSTANT error

* Add a clarifying comment and a new test case

* Add two more test cases to get to 100% code coverage

* Another test in pursuit of 100%

* Remove optional chaining on catch. The error is always going to be set

* Update changelog for v3.11.3

* 3.11.3

* Support overriding various package upload form data (#136)

* Support overriding various package upload form data

* adds support for squashfs deployments

---------

Co-authored-by: George Cook <[email protected]>

* Update changelog for v3.12.0

* 3.12.0

* Merge branch 'master' into v4

# Conflicts:
#	CHANGELOG.md
#	package-lock.json
#	package.json
#	src/RokuDeploy.spec.ts
#	src/RokuDeploy.ts
#	src/RokuDeployOptions.ts
- deleteDevChannel call was added which changed order of sideload post requests
- output file in makezip was changed to writefile

* readme info for retain staging dir deleted

* readded example

* fix package lock

* Fix Ci

---------

Co-authored-by: Christian-Holbrook <[email protected]>
Co-authored-by: Bronley Plumb <[email protected]>
Co-authored-by: George Cook <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants